Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Site-wide flag to disable "change version" #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bpmct opened this issue Feb 6, 2023 · 9 comments
Closed

Site-wide flag to disable "change version" #6051

bpmct opened this issue Feb 6, 2023 · 9 comments
Assignees
Labels
enterprise Enterprise-license / premium functionality

Comments

@bpmct
Copy link
Member

bpmct commented Feb 6, 2023

The "change version" feature is a great way for developers to try new features and roll back if something breaks.

Screenshot 2023-02-06 at 8 44 24 AM

However, some admins will want to ensure developers are on the latest version of a template to comply with security policies. For this reason, we should make a flag to disable this behavior across all workspaces. An enterprise customer has requested this feature

@bpmct bpmct added the enterprise Enterprise-license / premium functionality label Feb 6, 2023
@ammario
Copy link
Member

ammario commented Feb 6, 2023

Why did we allow changing version to begin with?

@bpmct
Copy link
Member Author

bpmct commented Feb 6, 2023

We should consider doing this per-template.

@dcarrion87
Copy link
Contributor

dcarrion87 commented Feb 6, 2023

This caused confusion when this came in. I forgot to post something about it.

Would love to see this just go. There's no reason in our environment for someone to ever rollback a version. It's actually a risk.

@bpmct
Copy link
Member Author

bpmct commented Feb 8, 2023

Why did we allow changing version to begin with?

It's nice to "roll back" if a breaking change occurred in a template version. We never had a feature for this in v1 until very recently, because images were the source of truth and any user could add image tags.

However, I totally agree it should be disable-able for deployments who want to have stricter policies for workspaces.

@ammario
Copy link
Member

ammario commented Feb 8, 2023

Maybe instead of "change version" we should introduce a concept of tags. Then:

  • Don't want rollbacks? Just deploy to template:master
  • Want rollbacks? Just tag coder templates tag template:master template:last before every template update

@bpmct
Copy link
Member Author

bpmct commented Feb 8, 2023

Sounds fantastic to me :)

@matifali
Copy link
Member

Maybe instead of "change version" we should introduce a concept of tags. Then:

  • Don't want rollbacks? Just deploy to template:master
  • Want rollbacks? Just tag coder templates tag template:master template:last before every template update.

#3775 is related in suggesting setting a message(description) on every push.

@matifali
Copy link
Member

matifali commented Feb 14, 2023

Also my comment on #6030 is related.

@bpmct

@bpmct
Copy link
Member Author

bpmct commented Mar 16, 2023

Closing in favor of #6635. We're definitely considering some form of tags/branches too

@bpmct bpmct closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise Enterprise-license / premium functionality
Projects
None yet
Development

No branches or pull requests

5 participants