Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Source code tab keeps loading for all users with member role #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matifali opened this issue Mar 23, 2023 · 5 comments · Fixed by #6776
Closed

Source code tab keeps loading for all users with member role #6763

matifali opened this issue Mar 23, 2023 · 5 comments · Fixed by #6776
Assignees
@Emyrk
Labels
site Area: frontend dashboard

Comments

@matifali
Copy link
Member

matifali commented Mar 23, 2023 •
edited
Loading

If they can't see the source code it's better to hide the tab.

cc: @BrunoQuaresma
@BrunoQuaresma
Copy link
Collaborator

Good catch!

@BrunoQuaresma BrunoQuaresma self-assigned this Mar 23, 2023
@BrunoQuaresma BrunoQuaresma added bug site Area: frontend dashboard labels Mar 23, 2023
@Emyrk Emyrk self-assigned this Mar 24, 2023
@Emyrk
Copy link
Member

Emyrk commented Mar 24, 2023

Yea, this is an issue. Essentially, the file and template have their own permissions. Currently file permissions are not tied to the template. There isn't a clean way to associate them right now.

For a hotfix, I will implement a way for the rbac to check all associated templates with a file. I will also open an issue to solve this more holistically in the future.

@Emyrk Emyrk mentioned this issue Mar 24, 2023
Merged
@BrunoQuaresma BrunoQuaresma removed their assignment Mar 27, 2023
@matifali
Copy link
Member Author

matifali commented Mar 27, 2023 •
edited
Loading

I still have this https://dev.coder.com
I can see the sourcecode tab and it keeps loading.
@Emyrk

@matifali
Copy link
Member Author

matifali commented Mar 27, 2023 •
edited
Loading

The latest commit has not been deployed yet. I am sorry. It has been fixed.

@Emyrk
Copy link
Member

Emyrk commented Mar 27, 2023

Yup just merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Emyrk Emyrk

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Users that can update a template can also read the file coder/coder
3 participants
@BrunoQuaresma @Emyrk @matifali