Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move app/terminal serving code to workspaceapps package #6914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deansheather opened this issue Mar 30, 2023 · 0 comments · Fixed by #6998
Closed

Move app/terminal serving code to workspaceapps package #6914

deansheather opened this issue Mar 30, 2023 · 0 comments · Fixed by #6998
Assignees
@deansheather
Milestone
Workspace Proxies

Comments

@deansheather
Copy link
Member

The current handlers for path apps, subdomain apps (middleware) and web terminal need to be moved to the workspaceapps package, with their reliance on coderd.API and the database fully removed.

These handlers should only rely on the workspace connection code and the workspaceapps.TicketProvider interface from #6913.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deansheather deansheather

Labels
None yet
Projects
None yet
Milestone
Workspace Proxies
Development

Successfully merging a pull request may close this issue.

chore: move app proxying code to workspaceapps pkg coder/coder
1 participant
@deansheather