Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update login-types response so that backend is the source of truth #784

Closed
@misskniss

Description

@misskniss

Overview

On the v1 login page, we currently receive a response for /api/auth/login-types like:

{
	"builtIn": false,
        "oauth": [{
             "type": "github",
             "redirect": "https://github.com/..."
             "background": "black",
             "svg": "..."
         }]
}

The v2 response will use objects instead of an array of strings that contain information such as:

  • key / ID
  • label (as rendered in the UI)
  • button SVG (for external providers)
  • validation

Note: not all of these are guaranteed for a first-pass at the issue, but the idea is that the FE shouldn't have to construct labels or icons when the BE can act as the source of truth.

Tasks

  • Login screen: return an array of json object for the providers. @vapurrmaid @deansheather to help define this. Backend should just return all the objects to render at the front so that we can easily add and remove login options. - BETA sp7
  • Ensure FE is updated synchronously with the backend change

Metadata

Metadata

Assignees

Labels

apiArea: HTTP APIsiteArea: frontend dashboard

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions