Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Frontend Workspace Create - build form #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks
Tracked by #678 ...
presleyp opened this issue Apr 1, 2022 · 9 comments
Closed
8 tasks
Tracked by #678 ...

Frontend Workspace Create - build form #801

presleyp opened this issue Apr 1, 2022 · 9 comments
Assignees
Labels
site Area: frontend dashboard
Milestone

Comments

@presleyp
Copy link
Contributor

presleyp commented Apr 1, 2022

Workspaces can have arbitrary parameters. The configuration can get long so we will use the style of the v1 Admin page, with tab sidebar.

  • build an input for each parameter type
  • storybook each input
  • get parameters
  • render an input for every parameter
  • test that a form is created with inputs from every type of parameter

Given that I have a workspace creation form, when I fill it out and submit it, a workspace should be created.

  • hook up api for workspace create
  • new workspace button
  • test that a workspace is created

Note this is still using SWR.

@presleyp presleyp self-assigned this Apr 1, 2022
@presleyp presleyp added V2 BETA site Area: frontend dashboard labels Apr 1, 2022
@presleyp presleyp added this to the V2 Beta milestone Apr 1, 2022
@presleyp
Copy link
Contributor Author

presleyp commented Apr 1, 2022

@kylecarbs what types of parameters are possible?

@presleyp
Copy link
Contributor Author

presleyp commented Apr 1, 2022

@kylecarbs another question, you mentioned wanting the edit form (which I'm thinking will be almost the same as the creation form) to be like the admin page, with a sidebar, but if the parameters are arbitrary, we won't know how to group them into tabs or name the tabs. What did you have in mind? I'm thinking of just having the Admin style sections but no sidebar.

@kylecarbs
Copy link
Member

I think all parameters can go under a tab named "Parameters" and that can contain a listing of them.

@kylecarbs
Copy link
Member

I wouldn't worry about the types for now, instead we can just make it a string.

@misskniss
Copy link

@presleyp do you have what you need answered for this one?

@presleyp
Copy link
Contributor Author

@misskniss no, but hopefully the meeting we'll have this week will clarify it

@presleyp presleyp assigned kylecarbs and unassigned presleyp Apr 28, 2022
@misskniss misskniss mentioned this issue May 6, 2022
16 tasks
@greyscaled
Copy link
Contributor

@kylecarbs is working on this one between 2022-05-11 and 2022-05-16. We will have a review meeting 2022-05-16 to check-in on where things are and to help test/review.

@misskniss
Copy link

@kylecarbs sounds like this one needs a backend ticket spun off for it.

@misskniss
Copy link

Closing this after a convo with Kyle. This work is complete and ready for iteration as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

No branches or pull requests

4 participants