Thanks to visit codestin.com
Credit goes to github.com

Skip to content

editing (and updating) workspace schedule should actually restart workspace #8086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpmct opened this issue Jun 19, 2023 · 3 comments
Closed

editing (and updating) workspace schedule should actually restart workspace #8086

bpmct opened this issue Jun 19, 2023 · 3 comments
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. stale This issue is like stale bread.

Comments

@bpmct
Copy link
Member

bpmct commented Jun 19, 2023

After editing your workspace schedule, it will send another start job. I feel like we should do a full stop, then start which is what we call our "restart" behavior. I noticed it runs the startup script again, this could lead to some unintended consequences if the startup script is only meant to run once per running workspace.

Screenshot 2023-06-19 at 1 10 58 PM
@bpmct bpmct added s2 Broken use cases or features (with a workaround). Only humans may set this. bug labels Jun 19, 2023
@matifali
Copy link
Member

I think we should do a complete Restart (Stop then Start) for the Update workspace action too. Same reason.

@bpmct
Copy link
Member Author

bpmct commented Jun 20, 2023

Agreed.

@bpmct bpmct changed the title editing workspace schedule should actually restart workspace editing (and updating) workspace schedule should actually restart workspace Jun 20, 2023
@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 18, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 1, 2024
@matifali
Copy link
Member

matifali commented Jan 1, 2024

It would be best if we could implement it in a way that unlinks the schedule from the workspace start/stop. Probably part of #8821.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matifali @bpmct