Thanks to visit codestin.com
Credit goes to github.com

Skip to content

☂️ Coder deployment health check #8971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
16 tasks done
matifali opened this issue Aug 8, 2023 · 13 comments · Fixed by #11572
Closed
16 tasks done

☂️ Coder deployment health check #8971

matifali opened this issue Aug 8, 2023 · 13 comments · Fixed by #11572
Assignees
@mtojek
Labels
☂️ epic An issue of issues
Milestone
healthcheck GA

Comments

@matifali
Copy link
Member

matifali commented Aug 8, 2023 •
edited by johnstcn
Loading

Background

In the context of #7748, we now have an excellent experimental health page available at coder.example.com/health.

image

Product Requirements

Before making it GA, it is essential to consider the following requirements.

Must have

Should have

Nice to have

cc: @bpmct
@cdr-bot cdr-bot bot added the feature label Aug 8, 2023
@matifali matifali added the ☂️ epic An issue of issues label Aug 8, 2023
@bpmct bpmct mentioned this issue Aug 8, 2023
Closed
@matifali matifali changed the title ☂️: Coder deployment health ☂️ Coder deployment health Aug 10, 2023
@matifali matifali mentioned this issue Aug 31, 2023
Closed
@bpmct
Copy link
Member

bpmct commented Sep 6, 2023

added #9558

@matifali matifali mentioned this issue Sep 15, 2023
Closed
@matifali matifali added this to the healthcheck GA milestone Sep 19, 2023
@bpmct bpmct changed the title ☂️ Coder deployment health ☂️ Coder deployment health check Sep 29, 2023
@mtojek mtojek self-assigned this Nov 10, 2023
@mtojek
Copy link
Member

mtojek commented Nov 10, 2023

I'm starting with #9470. Let's see how far I can go.

@mtojek
Copy link
Member

mtojek commented Nov 14, 2023

I prepared a draft navigating through the design & implemention details: notion page. Let's consider it to be kick off.

@johnstcn johnstcn mentioned this issue Nov 14, 2023
Closed
@BrunoQuaresma
Copy link
Collaborator

Should we add a task for the page redesign including all those changes in the API?

@mtojek
Copy link
Member

mtojek commented Nov 16, 2023

Replied in slack, let me copy it here:

Actually we can do the same way as we did last time, so somebody (me?) will finish the backend side, and then reassign issues to you

@matifali
Copy link
Member Author

@BrunoQuaresma yes you may create a new issue for design and add to the list and milestone.

@johnstcn johnstcn mentioned this issue Nov 20, 2023
Closed
@bpmct
Copy link
Member

bpmct commented Dec 3, 2023

👋🏼 Catching up now with these health check enhancements. This is awesome!

I noticed the health check does not show up in the bottom bar anymore. Is this just because dev.coder.com is currently healthy?

If not, are there plans to add it back again? I like that it can be discovered outside of the Deployment > Health when there errors so that an admin can identify and self-resolve without knowing the page exists or contacting support.

@BrunoQuaresma
Copy link
Collaborator

Yes, the warning is only displayed when it is unhealthy but we definitely need to improve its discoverability

@mtojek
Copy link
Member

mtojek commented Dec 4, 2023

@BrunoQuaresma Do you have spare time to implement the FE changes this week? I guess we all agreed on the design.

@BrunoQuaresma
Copy link
Collaborator

@mtojek sure thing. I was planning to take a look into the flakes but I'm going to prioritize the new health UI this week

@mtojek mtojek mentioned this issue Dec 5, 2023
Closed
3 tasks
This was referenced Dec 5, 2023
Merged
Merged
johnstcn added a commit that referenced this issue Dec 5, 2023
@johnstcn
fix(site/src/api/typesGenerated): generate HealthSection enums (#11049)
feaa989 
Relates to #8971

- Introduces a codersdk.HealthSection enum type
- Refactors existing references using strings to use new HealthSection type
@johnstcn johnstcn mentioned this issue Jan 11, 2024
Merged
@matifali
Copy link
Member Author

One last thing. Don't we also want to add a YAML page to each health check to allow the operator to copy raw health check response? Similar to previous behavior.
cc: @johnstcn @mtojek @BrunoQuaresma

@johnstcn
Copy link
Member

We could add a link to the API endpoint very cheaply?

@mtojek
Copy link
Member

mtojek commented Jan 12, 2024

@matifali Could you please a separate issue or post-GA epic? We have merged the healthcheck changes, so it is a bit late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
☂️ epic An issue of issues
Projects
None yet
Milestone
healthcheck GA
Development

Successfully merging a pull request may close this issue.

feat(site): remove experiment deployment_health_page coder/coder
5 participants
@BrunoQuaresma @johnstcn @matifali @mtojek @bpmct