Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SSH super slow when startup script fails #9203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ammario opened this issue Aug 18, 2023 · 1 comment · Fixed by #12650
Closed

SSH super slow when startup script fails #9203

ammario opened this issue Aug 18, 2023 · 1 comment · Fixed by #12650
Assignees
@ammario
Labels
networking Area: networking s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@ammario
Copy link
Member

ammario commented Aug 18, 2023

As title says, there is a ~5 second delay on ssh whenever it's printing my startup logs.
@ammario ammario added s2 Broken use cases or features (with a workaround). Only humans may set this. bug labels Aug 18, 2023
@spikecurtis spikecurtis added the networking Area: networking label Sep 26, 2023
@ammario
Copy link
Member Author

ammario commented Mar 18, 2024

I benchmarked the difference between SSHing into a workspace with a broken startup script and not, the former took ~12s and the latter ~6s. The issue may also be related to the printing of startup scripts via stdout. Either way I'm guessing there's low hanging fruit (i.e. not tailnet related) to gain a speedup and will investigate more deeply this week.

@ammario ammario self-assigned this Mar 18, 2024
@ammario ammario added s3 Bugs that confuse, annoy, or are purely cosmetic and removed s2 Broken use cases or features (with a workaround). Only humans may set this. labels Mar 18, 2024
ammario added a commit that referenced this issue Mar 18, 2024
@ammario
fix(codersdk): abort in-progress writes/reads when closing websocket
d195ae6 
Fixes #9203

Also, adds some basic tracing infrastructure that we can build upon for
more improvements.
@ammario ammario mentioned this issue Mar 18, 2024
Merged
ammario added a commit that referenced this issue Mar 18, 2024
@ammario
fix(codersdk): abort in-progress writes/reads when closing websocket
765edb8 
Fixes #9203

Also, adds some basic tracing infrastructure that we can build upon for
more improvements.
ammario added a commit that referenced this issue Mar 20, 2024
@ammario
fix(codersdk): abort in-progress writes/reads when closing websocket (#…
0d86dca 
…12650)

Fixes #9203

Related #12065

Also, adds some basic tracing infrastructure that we can build upon for more improvements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ammario ammario

Labels
networking Area: networking s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(codersdk): abort in-progress writes/reads when closing websocket coder/coder
2 participants
@spikecurtis @ammario