Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Review Linter #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
presleyp opened this issue Apr 9, 2022 · 1 comment
Closed

Review Linter #945

presleyp opened this issue Apr 9, 2022 · 1 comment
Labels
site Area: frontend dashboard

Comments

@presleyp
Copy link
Contributor

presleyp commented Apr 9, 2022

We have a doc on Code Conventions with a section on Small-Scale Code Conventions that covers the kinds of things linters can enforce. Look through the v2 linter config and the linter docs to determine if we can add enforcement of any of these rules to our codebase. You don't have to actually add the linter rules. Just report back to the frontend asynchronously or in Frontend Variety so we can discuss any questions and make tickets to do the work.

Spec

  1. Collect all of our code conventions from Code Conventions and FE V
  2. Scan for ones that have lint rules already enabled, ones that have lint rules that aren't yet written and ones that cannot be linted
  3. Configure the lint rules appropriately
  4. Document findings (lint-enabled, lint-disabled, no-lint) alongside conventions in some meaningful way
@presleyp presleyp added V2 BETA site Area: frontend dashboard labels Apr 9, 2022
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 19, 2022
@misskniss
Copy link

Please add your planning poker estimate with ZenHub @BrunoQuaresma

@f0ssel f0ssel closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

No branches or pull requests

6 participants