Thanks to visit codestin.com
Credit goes to github.com

Skip to content

health check endpoint: do not show healthy: false if Coder falls back to websockets #9470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #8971
bpmct opened this issue Aug 31, 2023 · 3 comments · Fixed by #10714
Closed
Tracked by #8971

health check endpoint: do not show healthy: false if Coder falls back to websockets #9470

bpmct opened this issue Aug 31, 2023 · 3 comments · Fixed by #10714
Assignees
@mtojek
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Milestone
healthcheck GA

Comments

@bpmct
Copy link
Member

bpmct commented Aug 31, 2023

If upgrade: derp doesn't work, Coder passively falls back to WebSockets. This is slightly slower but not significant to my knowledge. We should not show errors in this case, but perhaps a warning?
@cdr-bot cdr-bot bot added the bug label Aug 31, 2023
@matifali
Copy link
Member

matifali commented Aug 31, 2023 •
edited
Loading

@bpmct this looks related to #8966 , also can you add it to #8971?

@bpmct
Copy link
Member Author

bpmct commented Aug 31, 2023

It is related, but slightly different :) added to the umbrella issue

@bpmct bpmct mentioned this issue Aug 31, 2023
Closed
16 tasks
@matifali matifali added this to the healthcheck GA milestone Sep 19, 2023
@matifali matifali added the s3 Bugs that confuse, annoy, or are purely cosmetic label Oct 2, 2023
@mtojek mtojek self-assigned this Nov 10, 2023
@mtojek
Copy link
Member

mtojek commented Nov 10, 2023

I'm going with this one.

This was referenced Nov 10, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
healthcheck GA
3 participants
@matifali @mtojek @bpmct