Conversation
Codecov Report
@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
- Coverage 67.44% 67.11% -0.33%
==========================================
Files 259 260 +1
Lines 15161 15374 +213
Branches 152 152
==========================================
+ Hits 10225 10318 +93
- Misses 3910 4003 +93
- Partials 1026 1053 +27
Continue to review full report at Codecov.
|
53b6677 to
b081562
Compare
180ed3f to
3d1ea08
Compare
| // for proxying via Coder. We don't proxy all TURN connections, | ||
| // because that'd exclude the possibility of a customer using | ||
| // their own TURN server. | ||
| reservedAddress = "127.0.0.1:12345" |
There was a problem hiding this comment.
(question): Do we have to hard-code port 12345? Can we just ask for whatever port is free and advertise that port?
There was a problem hiding this comment.
I'll clarify that it doesn't actually use port 12345. This is just used for detection. It'd technically block a customer from using 127.0.0.1:12345 though, which maybe is an issue.
There was a problem hiding this comment.
Gotcha. If we get to that point, we could maybe just probe a few times or allow specifying this in config.
| replace github.com/briandowns/spinner => github.com/kylecarbs/spinner v1.18.2-0.20220329160715-20702b5af89e | ||
|
|
||
| // Required until https://github.com/pion/ice/pull/444 is merged. | ||
| replace github.com/pion/ice/v2 => github.com/kylecarbs/ice/v2 v2.1.8-0.20220414143940-b5b2f89c4a4f |
There was a problem hiding this comment.
I think we can remove this! v2.2.4 just got tagged!
|
🎉 Happy 1000th PR 🎉 |
This adds a configuration option for
ICEServerswhen initializing Coder.TURN proxying cannot be disabled right now, but using the current abstraction clients could force P2P.