Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: reduce maxWorkers in jest tests #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Apr 14, 2022

Summary:

When maxWorkers is high, there's a bug in jest that causes OOM kills.
Unfortunately, CI is experiencing this as well as local. For now, the best solution
is just reducing maxWorkers.

Resolves: #1004

Summary:

This spot has caused slowdowns locally. This PR is an investigation (to trigger CI)
to see if reducing maxWorkers speeds up test/js.
@greyscaled greyscaled requested a review from a team as a code owner April 14, 2022 16:15
@greyscaled greyscaled self-assigned this Apr 14, 2022
@greyscaled greyscaled added bug 🐛 site Area: frontend dashboard labels Apr 14, 2022
@greyscaled
Copy link
Contributor Author

This alongside #1005 should chop off a few minutes from test/js cc @kylecarbs

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1006 (b5cfc40) into main (3304db0) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
- Coverage   66.90%   66.79%   -0.11%     
==========================================
  Files         253      253              
  Lines       14941    14941              
  Branches      135      135              
==========================================
- Hits         9996     9980      -16     
- Misses       3950     3963      +13     
- Partials      995      998       +3     
Flag Coverage Δ
unittest-go-macos-latest 53.62% <ø> (+0.16%) ⬆️
unittest-go-postgres- 66.70% <ø> (+0.09%) ⬆️
unittest-go-ubuntu-latest 56.09% <ø> (-0.14%) ⬇️
unittest-go-windows-2022 53.06% <ø> (+0.03%) ⬆️
unittest-js 61.61% <ø> (ø)
Impacted Files Coverage Δ
pty/start_other.go 64.70% <0.00%> (-23.53%) ⬇️
coderd/database/db.go 55.17% <0.00%> (-13.80%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
coderd/provisionerdaemons.go 63.97% <0.00%> (-2.06%) ⬇️
provisionerd/provisionerd.go 80.58% <0.00%> (-0.59%) ⬇️
peer/conn.go 78.17% <0.00%> (ø)
coderd/database/queries.sql.go 84.07% <0.00%> (+0.41%) ⬆️
cli/cliui/agent.go 82.45% <0.00%> (+5.26%) ⬆️
coderd/parameter/compute.go 80.74% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3304db0...b5cfc40. Read the comment docs.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greyscaled greyscaled merged commit 30877bb into main Apr 14, 2022
@greyscaled greyscaled deleted the vapurrmaid/ci-maxworkers branch April 14, 2022 16:23
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Investigate test/js taking too long in CI
3 participants