fix: display health alert in DeploymentBannerView
#10193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Oct 13, 2023
| @@ -242,7 +240,7 @@ const styles = { | |||
| marginBottom: theme.spacing(1), | |||
| color: theme.palette.text.primary, | |||
| fontSize: 14, | |||
| lineHeight: "120%", | |||
| lineHeight: "150%", | |||
There was a problem hiding this comment.
I'm wondering if this could be changed to just 1.5, to work better with CSS inheritance
There was a problem hiding this comment.
Not sure what you mean by "work better with CSS inheritance". 150% and 1.5 mean the same thing in CSS. 😅 and I prefer percent, because the unit makes it clearer what is happening imo.
There was a problem hiding this comment.
I wish they were the same, but they aren't
site/src/components/Dashboard/DeploymentBanner/DeploymentBannerView.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9692