Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(cli): fix TestServer flake due to DNS lookup #10390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

mafredri
Copy link
Member

Occasionally we see networking issues on GitHub actions, and DNS lookups are just an extra point-of-failure. I've added a fast-track list for example.com and google.com when running as a test. This should hopefully help reduce flakes like this:

https://github.com/coder/coder/actions/runs/6616368262/job/17970506089

@mafredri mafredri force-pushed the mafredri/test-cli-fix-dns-flake branch from 620009e to f2e3100 Compare October 23, 2023 17:48
@mafredri mafredri merged commit eac155a into main Oct 24, 2023
@mafredri mafredri deleted the mafredri/test-cli-fix-dns-flake branch October 24, 2023 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants