feat: parse resource metadata values as markdown #10521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenos-nachos
suggested changes
Nov 6, 2023
Contributor
buenos-nachos
left a comment
There was a problem hiding this comment.
Everything seems to make sense to me. Just had some clarifying questions about how things are set up, and flagged a bug with the memoization
buenos-nachos
approved these changes
Nov 7, 2023
Contributor
buenos-nachos
left a comment
There was a problem hiding this comment.
I'm not going to block on this, but I still feel like it might make sense to give memo a custom comparison function
My worry is that with how subtle the memoization bug was here, anyone using the component in the future might accidentally have the exact same problem (and worse yet, might not realize that they're doing anything wrong)
Member
Author
|
yeah yeah, I can use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/terraform-provider-coder#115
Parse resource metadata values as a limited subset of markdown, that will reduce the ability to render values which misbehave/break out of boxes/cause weird layout issues
Only enable "click to copy" on simple, unformatted text. This seemed to be a nice compromise between complexity and functionality.
CopyableValuewhich looks weird and feels bad, and deciding what value should be copied if it has bold text, etc.