Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site/src/api): getDeploymentDAUs: truncate tz_offset to whole number #10563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Nov 7, 2023

Fixes #10562

Per #7647 (comment) it appears that this was the intended behaviour.

@johnstcn johnstcn requested a review from Emyrk November 7, 2023 15:26
@johnstcn johnstcn requested review from Emyrk, mafredri and BrunoQuaresma and removed request for Emyrk November 7, 2023 15:26
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my golang mind just assumed it would be an integer and truncate 🤦‍♂️

@johnstcn johnstcn merged commit 8441c36 into main Nov 7, 2023
@johnstcn johnstcn deleted the cj/daus-fractional-tz-offset branch November 7, 2023 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(site): DAUs chart fails to load with fractional-hour tz offset
2 participants