chore: move moons out of experimental mode #10716
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was in experimental for a long time.
|
This should be reopened |
deansheather
reviewed
Dec 8, 2023
| @@ -25,7 +25,6 @@ func Test_ProxyCRUD(t *testing.T) { | |||
|
|
|||
| dv := coderdtest.DeploymentValues(t) | |||
| dv.Experiments = []string{ | |||
There was a problem hiding this comment.
Why keep the deployment values if you're not setting any experiments?
| // Use proxy health to return the healthy workspace proxy hostnames. | ||
| f := api.ProxyHealth.ProxyHosts | ||
| api.AGPL.WorkspaceProxyHostsFn.Store(&f) | ||
| // Proxy health is a moon feature. |
There was a problem hiding this comment.
Suggested change
| // Proxy health is a moon feature. |
| @@ -112,14 +112,14 @@ export const Sidebar: React.FC = () => { | |||
| <SidebarNavItem href="network" icon={<SidebarNavItemIcon icon={Globe} />}> | |||
| Network | |||
| </SidebarNavItem> | |||
| {dashboard.experiments.includes("moons") && ( | |||
| { | |||
|
rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was in experimental for a long time.