refactor: Rename Icons and add stories #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
presleyp
commented
Apr 19, 2022
•
- rename all icons to end in Icon except Logo
- get rid of icons index file
- replace icons test with stories
|
Should we update the stories filenames to be |
Codecov Report
@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
- Coverage 66.58% 66.54% -0.04%
==========================================
Files 262 258 -4
Lines 15660 15471 -189
Branches 152 152
==========================================
- Hits 10427 10295 -132
+ Misses 4164 4127 -37
+ Partials 1069 1049 -20
Continue to review full report at Codecov.
|
greyscaled
approved these changes
Apr 19, 2022
|
@presleyp can you update the PR name to be semantic? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.