Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(enterprise/coderd/proxyhealth): properly defer healthCheckDuration observe #10848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix(enterprise/coderd/proxyhealth): properly defer healthCheckDuration observe #10848

merged 1 commit into from
Nov 23, 2023

Conversation

johnstcn
Copy link
Member

Drive-by linter fix. We weren't properly calling time.Since() in a defer().

@johnstcn johnstcn requested a review from mtojek November 23, 2023 15:13
@johnstcn johnstcn self-assigned this Nov 23, 2023
mtojek
mtojek approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnstcn johnstcn enabled auto-merge (squash) November 23, 2023 15:15
@johnstcn johnstcn merged commit f342d10 into main Nov 23, 2023
@johnstcn johnstcn deleted the cj/hotfix-proxyhealth-defer branch November 23, 2023 15:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mtojek