Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(coderd): remove nil ptr deref in watchWorkspace #10859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

mafredri
Copy link
Member

Fixes #10849

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-pasta strikes again!

@mafredri
Copy link
Member Author

mafredri commented Nov 24, 2023

Indeed. And this seems like something that should be possible to catch via linter/static analysis. Has a preceding if err != nil { return }, so err must be nil? 🤔

@mafredri mafredri enabled auto-merge (squash) November 24, 2023 15:09
@mafredri mafredri merged commit e73901c into main Nov 24, 2023
@mafredri mafredri deleted the mafredri/fix-coderd-watch-workspace-nil-ptr-deref branch November 24, 2023 15:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: TestSSH/ExitOnStop
2 participants