feat: manage health settings using Coder API #10861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Nov 28, 2023
| @@ -232,6 +233,52 @@ func TestDebugHealth(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestHealthSettings(t *testing.T) { | |||
There was a problem hiding this comment.
- Can we add a test case where we un-dismiss?
- This should be audited, so we want to add an auditor and assert that an audit action took place.
There was a problem hiding this comment.
This should be audited, so we want to add an auditor and assert that an audit action took place.
Do you know any good code examples I can review first?
There was a problem hiding this comment.
There was a problem hiding this comment.
- I added support for auditing, but I have no idea if this is sufficient. Keep in mind that "health settings" are stored as site configs, so in this case, the resource (and its ID) is artificial.
There was a problem hiding this comment.
You can add a mock auditor into the unit tests and assert that the changes were audited as expected.
johnstcn
approved these changes
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #10712
This PR exposes new API endpoints to modify health page settings.
Follow-up:
dismissedproperty via/debug/health