chore(site): use variable font for inter #10903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
reviewed
Nov 27, 2023
| @@ -1,7 +1,7 @@ | |||
| export const borderRadius = 8; | |||
| export const MONOSPACE_FONT_FAMILY = | |||
| "'IBM Plex Mono', 'Lucida Console', 'Lucida Sans Typewriter', 'Liberation Mono', 'Monaco', 'Courier New', Courier, monospace"; | |||
| export const BODY_FONT_FAMILY = `"Inter", system-ui, sans-serif`; | |||
| export const BODY_FONT_FAMILY = `"Inter Variable", system-ui, sans-serif`; | |||
There was a problem hiding this comment.
Just to be on the safe side, I feel like it'd be good to include Inter as the second variable in the stack
We won't be serving it up, but if the user just happens to have it downloaded, they'll still get a pretty equivalent UI
There was a problem hiding this comment.
I think it is too much to be honest since this font will be cached on the first load.
Parkreiner
approved these changes
Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using variable fonts, we just need to import the font once to have access to all its weights making imports faster and flexibility to change the values at any time.