feat: add support for coder_env
#11102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d18e00c to
b63880b
Compare
b63880b to
04ac5cc
Compare
0fc68f9 to
983cad8
Compare
matifali
reviewed
Dec 8, 2023
johnstcn
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
I think this behaviour is fine.
LGTM
There's definitely a set of environment variables we don't want folks to be able to override, lest they brick their workspace.
So this behaviour of not overriding is fine for now.
Perhaps later we could have a denylist of environment variables, but that's not for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
coder_env(coder/terraform-provider-coder#174).The terraform/proto structure is conducive towards allowing additional logic in the future, as discussed in #10166.
For now, we simply piggy-back on the
workspace_agents.environment_variablescolumn with the additional envs. It felt premature to add a separate table and logic in the agent for this, however, a downside is that conflicts are silently ignored (we simply don't set the env if it's already set on the agent resource or by another module).Ideas for non-silent discard are welcome. And if preferred, I can create the
workspace_agent_envtable with accompanying agent logic to process the extra envs. The agent can then log the conflict.Fixes #10166