Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(coderd/database/dbfake): fix pq test flake in TestStart_Starting #11384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2024
Merged

chore(coderd/database/dbfake): fix pq test flake in TestStart_Starting #11384

merged 1 commit into from
Jan 3, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jan 3, 2024 •
edited
Loading

test-go-pg got skipped in #11381 so this snuck through.

    start_test.go:423: 
        	Error Trace:	/home/runner/actions-runner/_work/coder/coder/coderd/database/dbfake/dbfake.go:197
        	            				/home/runner/actions-runner/_work/coder/coder/cli/start_test.go:423
        	Error:      	Received unexpected error:
        	            	pq: invalid input syntax for type json
        	Test:       	TestStart_Starting
        	Messages:   	acquire starting job

@johnstcn johnstcn requested a review from spikecurtis January 3, 2024 12:19
@johnstcn johnstcn self-assigned this Jan 3, 2024
@johnstcn johnstcn added the hotfix label Jan 3, 2024
cdr-bot[bot]
cdr-bot bot approved these changes Jan 3, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn johnstcn merged commit 068e730 into main Jan 3, 2024
@johnstcn johnstcn deleted the cj/flake/cli-test-start-starting branch January 3, 2024 12:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnstcn