refactor: Add components for styling forms #1169
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
- Coverage 66.53% 66.23% -0.30%
==========================================
Files 263 265 +2
Lines 16427 16593 +166
Branches 156 157 +1
==========================================
+ Hits 10929 10991 +62
- Misses 4377 4462 +85
- Partials 1121 1140 +19
Continue to review full report at Codecov.
|
|
|
||
| export interface FullPageFormProps { | ||
| title: string | ||
| detail?: React.ReactNode |
There was a problem hiding this comment.
Had to read up again to remind myself what exactly is considered as a ReactNode
anything that is renderable inside of JSX, this is NOT the same as what can be rendered by a component!
There was a problem hiding this comment.
@jsjoeio do you think it's the wrong type? I took it from FormTitle which is where this ends up but I could change it.
There was a problem hiding this comment.
Oh no, sorry, I think it's right. It just surprised me, that's all. I thought detail might have been a string when I first saw the component. Whatever you think is best!
* Add FormFooter * Add FullPageForm * Lint * Make detail optional * Use Language
I thought some reusable components would help us with our create/edit forms.
See stories for example usage - the
FormFootergoes inside aformwhich goes inside theFullPageForm.