Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: force desktop view on mobile #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2022
Merged

chore: force desktop view on mobile #1214

merged 2 commits into from
Apr 28, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes #763

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner April 28, 2022 18:39
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #1214 (58895e4) into main (1661588) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
- Coverage   65.48%   65.43%   -0.05%     
==========================================
  Files         265      265              
  Lines       16950    16950              
  Branches      157      157              
==========================================
- Hits        11099    11091       -8     
- Misses       4692     4699       +7     
- Partials     1159     1160       +1
Flag Coverage Δ
unittest-go-macos-latest 52.85% <ø> (-0.03%) ⬇️
unittest-go-postgres- 64.61% <ø> (-0.09%) ⬇️
unittest-go-ubuntu-latest 55.41% <ø> (-0.03%) ⬇️
unittest-go-windows-2022 52.50% <ø> (+<0.01%) ⬆️
unittest-js 66.50% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/listen.go 85.71% <0.00%> (-5.05%) ⬇️
coderd/workspaceagents.go 55.59% <0.00%> (-2.56%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
peer/conn.go 80.20% <0.00%> (-0.77%) ⬇️
provisionerd/provisionerd.go 76.70% <0.00%> (ø)
provisioner/terraform/provision.go 71.39% <0.00%> (+0.43%) ⬆️
agent/agent.go 68.43% <0.00%> (+2.12%) ⬆️
cli/cliui/agent.go 82.45% <0.00%> (+5.26%) ⬆️
codersdk/provisionerdaemons.go 67.60% <0.00%> (+5.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1661588...58895e4. Read the comment docs.

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) April 28, 2022 19:12
presleyp
presleyp approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I look forward to having real responsive design but this is good for now!

@BrunoQuaresma BrunoQuaresma merged commit 00cac37 into main Apr 28, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/763/force-desktop-view branch April 28, 2022 21:05
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@BrunoQuaresma @kylecarbs
chore: force desktop view on mobile (#1214)
8bf1ffc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Force desktop view on mobile with (metatag)
3 participants
@BrunoQuaresma @presleyp @misskniss