Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: set node callback each time we reinit in servertailnet [backport] #12150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

spikecurtis
Copy link
Contributor

Backports #12140 to the release-2.8 branch

…ailnet (#12140)

I think this will resolve #12136 but lets get a proper test at the system level before closing.

Before this change, we only register the node callback at start of day for the server tailnet.  If the coordinator changes, like we know happens when we are licensed for the PGCoordinator, we close the connection to the old coord, and open a new one to the new coord.

The callback is designed to direct the updates to the new coordinator, but there is nothing that specifically triggers it to fire after we connect to the new coordinator.

If we have STUN, then period re-STUNs will generally get it to fire eventually, but without STUN it we could go indefinitely without a callback.

This PR changes the servertailnet to re-register the callback each time we reconnect to the coordinator.  Registering a callback (even if it's the same callback) triggers an immediate call with our node information, so the new coordinator will have it.
@spikecurtis spikecurtis requested review from coadler and bpmct February 15, 2024 04:45
@spikecurtis spikecurtis changed the title fix: set node callback each time we reinit the coordinator in servertailnet [backport] fix: set node callback each time we reinit in servertailnet [backport] Feb 15, 2024
@spikecurtis spikecurtis requested a review from sreya February 15, 2024 04:47
@spikecurtis spikecurtis merged commit ae1be27 into release-2.8 Feb 15, 2024
@spikecurtis spikecurtis deleted the spike/release-2.8-12140-backport branch February 15, 2024 04:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants