feat: implement create org commands from cli #12308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Feb 27, 2024
cli/organizationmanage.go
Outdated
| return fmt.Errorf("organization %q already exists", orgName) | ||
| } | ||
|
|
||
| // Confirm deletion of the template. |
There was a problem hiding this comment.
Suggested change
| // Confirm deletion of the template. |
| IsConfirm: true, | ||
| Default: cliui.ConfirmNo, | ||
| }) | ||
| if err != nil { |
There was a problem hiding this comment.
Handle cliui.Canceled? Just exit with code 1 and show no error (didn't test, maybe that's what happens).
There was a problem hiding this comment.
I just confirmed if the context is cancelled, then it is exit code 1 with
$ coder orgs create test
> Are you sure you want to create an organization with the name test ?
This action is irreversible. (yes/no)
Encountered an error running "coder organizations create"
context canceled
There was a problem hiding this comment.
The problem is that we print context cancelled. Should just exit silently with 1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a command to add organizations because the only other way currently is with a curl command. When developing multi-org stuff, it is a little annoying to have to do.
The command is hidden and should not be made visible while the action is irreversible. Organizations cannot be deleted at the moment.