fix: Use environment variables for agent authentication #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a mistake when adding the committer fields 🤦.
Using files led to situations where running "coder server --dev" would break `gitssh`. This is applicable in a production environment too. Users should be able to log into another Coder deployment from their workspace. Users can still set "CODER_URL" if they'd like with agent env vars!
Codecov Report
@@ Coverage Diff @@
## main #1238 +/- ##
==========================================
- Coverage 65.84% 65.73% -0.11%
==========================================
Files 272 270 -2
Lines 17875 17865 -10
Branches 192 192
==========================================
- Hits 11770 11744 -26
- Misses 4878 4885 +7
- Partials 1227 1236 +9
Continue to review full report at Codecov.
|
code-asher
approved these changes
Apr 30, 2022
code-asher
reviewed
Apr 30, 2022
|
My workspaces are not starting for some reason so I was not able to fully test but I was able to at least confirm that setting One unexpected struggle I had was that I was running from a v1 workspace where |
This was referenced May 4, 2022
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
* fix: Update GIT_COMMITTER_NAME to use username This was a mistake when adding the committer fields 🤦. * fix: Use environment variables for agent authentication Using files led to situations where running "coder server --dev" would break `gitssh`. This is applicable in a production environment too. Users should be able to log into another Coder deployment from their workspace. Users can still set "CODER_URL" if they'd like with agent env vars!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using files led to situations where running "coder server --dev" would
break
gitssh. This is applicable in a production environment too. Usersshould be able to log into another Coder deployment from their workspace.
Users can still set "CODER_URL" if they'd like with agent env vars!