Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site): retry and debug passing build parameters options #12384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrunoQuaresma merged 9 commits into from
Mar 4, 2024
Merged

fix(site): retry and debug passing build parameters options #12384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cf51f13
Chosmetic changes
BrunoQuaresma Mar 1, 2024
1bbe8d0
Support build parameters on retry and debug actions
BrunoQuaresma Mar 1, 2024
ae3f3f0
Extract retry button
BrunoQuaresma Mar 1, 2024
c3a8dd9
Extract debug button
BrunoQuaresma Mar 1, 2024
5858c8d
Add story for checking debug
BrunoQuaresma Mar 1, 2024
642e475
Fix workspace tests warnings
BrunoQuaresma Mar 1, 2024
a9e122f
Add tests for retry with build parameters
BrunoQuaresma Mar 1, 2024
7d245c5
Add test for debug
BrunoQuaresma Mar 1, 2024
79673eb
Fix test errors
BrunoQuaresma Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix workspace tests warnings
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Mar 1, 2024
commit 642e47598293422dc358ae88a8207b3c49545020
9 changes: 6 additions & 3 deletions site/src/components/FullPageLayout/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,17 @@ interface SidebarIconButton extends ComponentProps<typeof TopbarIconButton> {
isActive: boolean;
}

export const SidebarIconButton: FC<SidebarIconButton> = (props) => {
export const SidebarIconButton: FC<SidebarIconButton> = ({
isActive,
...buttonProps
}) => {
return (
<TopbarIconButton
css={[
{ opacity: 0.75, "&:hover": { opacity: 1 } },
props.isActive && styles.activeSidebarIconButton,
isActive && styles.activeSidebarIconButton,
]}
{...props}
{...buttonProps}
/>
);
};
Expand Down
10 changes: 10 additions & 0 deletions site/src/testHelpers/handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,12 @@ export const handlers = [
rest.put("/api/v2/workspaces/:workspaceId/extend", async (req, res, ctx) => {
return res(ctx.status(200));
}),
rest.get(
"/api/v2/workspaces/:workspaceId/resolve-autostart",
async (req, res, ctx) => {
return res(ctx.status(200), ctx.json({ parameter_mismatch: false }));
},
),

// workspace builds
rest.post("/api/v2/workspaces/:workspaceId/builds", async (req, res, ctx) => {
Expand Down Expand Up @@ -438,4 +444,8 @@ export const handlers = [
rest.get("/api/v2/workspaceagents/:agent/listening-ports", (_, res, ctx) => {
return res(ctx.status(200), ctx.json(M.MockListeningPortsResponse));
}),

rest.get("/api/v2/integrations/jfrog/xray-scan", (_, res, ctx) => {
return res(ctx.status(404));
}),
Copy link
Member

@Kira-Pilot Kira-Pilot Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we add these?

Copy link
Contributor Author

@BrunoQuaresma BrunoQuaresma Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid getting unhandled request warnings during tests. The warning was introduced many PRs ago but I only noticed it now since it was messing with the output for my tests so I just fixed it.

];