fix(cli): generate correctly named file in DumpHandler #12409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Mar 4, 2024
cli/root.go
Outdated
| @@ -992,7 +992,7 @@ func DumpHandler(ctx context.Context) { | |||
| if err != nil { | |||
| dir = os.TempDir() | |||
| } | |||
| fpath := filepath.Join(dir, fmt.Sprintf("coder-agent-%s.dump", time.Now().Format("2006-01-02T15:04:05.000Z"))) | |||
| fpath := filepath.Join(dir, fmt.Sprintf("coder-%s-%s.dump", name, time.Now().Format("2006-01-02T15:04:05.000Z"))) | |||
There was a problem hiding this comment.
out of scope: we should probably not use colons in the file path as that's a forbidden character in NTFS.
There was a problem hiding this comment.
Good catch, it's such a small change I could piggy back it on this one.
johnstcn
approved these changes
Mar 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed we always write the filenames with "agent" in the name, this fixes that.
EDIT: As a bonus we did
s/:/-/on time so that files are safe on any filesystem, e.g. NTFS.EDIT2: As a bonus2 we use
time.Now().UTC()since our formatting string appendsZto the filename, but we were actually rendering the local time.