Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Use atomic value for logger in peer #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2022
Merged

fix: Use atomic value for logger in peer #1257

merged 1 commit into from
May 2, 2022

Conversation

kylecarbs
Copy link
Member

This caused many races where logs would escape the tests
by milliseconds. By using an atomic on the logger,
we can fix all of it!

@kylecarbs
fix: Use atomic value for logger in peer
c20cfaa 
This caused many races where logs would escape the tests
by milliseconds. By using an atomic on the logger,
we can fix all of it!
@kylecarbs kylecarbs requested a review from coadler May 2, 2022 16:31
@kylecarbs kylecarbs self-assigned this May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022 •
edited
Loading

Codecov Report

Merging #1257 (c20cfaa) into main (c2b5009) will increase coverage by 0.04%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
+ Coverage   66.01%   66.06%   +0.04%     
==========================================
  Files         275      275              
  Lines       17949    17948       -1     
  Branches      216      216              
==========================================
+ Hits        11849    11857       +8     
+ Misses       4859     4855       -4     
+ Partials     1241     1236       -5
Flag Coverage Δ
unittest-go-macos-latest 53.36% <88.23%> (+0.15%) ⬆️
unittest-go-postgres- 64.93% <88.23%> (-0.02%) ⬇️
unittest-go-ubuntu-latest 55.82% <88.23%> (+0.10%) ⬆️
unittest-go-windows-2022 51.69% <88.23%> (+<0.01%) ⬆️
unittest-js 70.69% <ø> (ø)
Impacted Files Coverage Δ
peer/channel.go 86.12% <66.66%> (+1.73%) ⬆️
peer/conn.go 80.34% <90.32%> (+3.17%) ⬆️
peerbroker/listen.go 82.35% <0.00%> (-5.05%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
coderd/workspaceagents.go 56.04% <0.00%> (-1.87%) ⬇️
provisionerd/provisionerd.go 76.57% <0.00%> (+0.80%) ⬆️
codersdk/provisionerdaemons.go 67.60% <0.00%> (+5.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b5009...c20cfaa. Read the comment docs.

@kylecarbs kylecarbs merged commit 3176e10 into main May 2, 2022
@kylecarbs kylecarbs deleted the peerlog branch May 2, 2022 16:50
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Use atomic value for logger in peer (#1257)
6e6e447 
This caused many races where logs would escape the tests
by milliseconds. By using an atomic on the logger,
we can fix all of it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @coadler @misskniss