Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: force logs to flush on close in peer.(*Conn) #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 3, 2022
Merged

fix: force logs to flush on close in peer.(*Conn) #1268

merged 3 commits into from
May 3, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented May 3, 2022

No description provided.

@coadler coadler self-assigned this May 3, 2022
@coadler coadler requested a review from kylecarbs May 3, 2022 13:29
@codecov
Copy link

codecov bot commented May 3, 2022 •
edited
Loading

Codecov Report

Merging #1268 (4e9dab4) into main (5dcaf94) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
- Coverage   66.10%   65.75%   -0.36%     
==========================================
  Files         276      273       -3     
  Lines       18146    18026     -120     
  Branches      216      216              
==========================================
- Hits        11996    11853     -143     
- Misses       4911     4931      +20     
- Partials     1239     1242       +3
Flag Coverage Δ
unittest-go-macos-latest 53.31% <100.00%> (+0.10%) ⬆️
unittest-go-postgres- 64.77% <100.00%> (-0.34%) ⬇️
unittest-go-ubuntu-latest 55.79% <100.00%> (+0.03%) ⬆️
unittest-go-windows-2022 ?
unittest-js 70.69% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 79.85% <100.00%> (-1.74%) ⬇️
cli/configssh.go 62.04% <0.00%> (-6.57%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
agent/agent.go 64.66% <0.00%> (-2.48%) ⬇️
provisionerd/provisionerd.go 75.76% <0.00%> (-2.41%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dcaf94...4e9dab4. Read the comment docs.

kylecarbs
kylecarbs approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sync() is wise!

@coadler coadler merged commit eda85a0 into main May 3, 2022
@coadler coadler deleted the colin/peer-log branch May 3, 2022 13:36
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@coadler @kylecarbs
fix: force logs to flush on close in peer.(*Conn) (#1268)
16f915f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @kylecarbs @misskniss