chore: allow search by build params in workspace search filter #12694
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
061909b to
3fe88c4
Compare
8112eb2 to
aecf9c0
Compare
aca699c to
2bcdbd9
Compare
2bcdbd9 to
819e861
Compare
| @@ -184,6 +194,40 @@ WHERE | |||
| workspaces.owner_id = @owner_id | |||
| ELSE true | |||
| END | |||
| -- Filter by build parameter | |||
| -- @has_param will match any build that includes the parameter. | |||
| AND CASE WHEN array_length(@has_param :: text[], 1) > 0 THEN | |||
There was a problem hiding this comment.
As this operates on 1 and 0, maybe we can simplify it:
AND (
array_length(@has_param :: text[], 1) = 0
OR EXISTS (
SELECT 1
FROM workspace_build_parameters
WHERE
workspace_build_parameters.workspace_build_id = latest_build.id AND
workspace_build_parameters.name ILIKE ANY(@has_param)
)
)There was a problem hiding this comment.
that is true, however we have this CASE WHEN syntax for other params, and other array style params. Do you feel it's worth having a differing syntax?
There was a problem hiding this comment.
I admit that I like the consistency, although it is tempting to simplify this query wherever it is possible. Anyway, this is not a must-have, your syntax is also correct 👍
There was a problem hiding this comment.
I'm going to decide to leave it for consistency. All the params are identical right now in how they are handled.
| { | ||
| Name: "ParamExcessValue", | ||
| Query: "param:foo=bar=baz", | ||
| ExpectedErrorContains: "can only contain 1 '='", |
There was a problem hiding this comment.
Actually, it would be great to see if the user can set the parameter value to a random string with =.
There was a problem hiding this comment.
You are correct, an equals sign in the right hand side will break this.
The parser here is pretty dumb. 😢
What this does
closes: #10661
Adds a
param:<name>[=<value>]option to the workspaces search.param:namewill match any workspace that has the parameter valueparam:name=valuewill match only if the parameter has the value given.param:name=value1 param:name=value2will match both.Demo:
Screencast.from.2024-03-20.14-58-40.webm
Wildcard support
I want to get this PR in and working in the exact match state. I have an open PR for allowing a more regex style support.