Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(coderd): skip logging error for cancelled query in agent report stats #12730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix(coderd): skip logging error for cancelled query in agent report stats #12730

merged 1 commit into from
Mar 25, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Mar 22, 2024 •
edited
Loading

Seen in the wild: https://github.com/coder/coder/actions/runs/8394006766/job/22990239723?pr=12669

    t.go:108: 2024-03-22 17:19:38.582 [erro]  agentrpc: failed to load template schedule bumping activity, defaulting to bumping by 60min  owner=testuser  workspace_name=peaceful-snyder8-a6k  agent_name=example  request_id=7a002cc6-f2b9-4118-a927-d53fa6be6c02  workspace_id=98529c95-0b47-424a-81eb-d40c3619cb4f  template_id=0ef6beff-707c-4ae8-81a9-4045b56cf388 ...
        error= fetch object:
                   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).GetTemplateByID.fetch[...].func1
                       /home/runner/actions-runner/_work/coder/coder/coderd/database/dbauthz/dbauthz.go:400
                 - pq: canceling statement due to user request
         *** slogtest: log detected at level ERROR; TEST FAILURE ***

@mafredri Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mafredri and the rest of your teammates on Graphite Graphite

@mafredri mafredri requested a review from Emyrk March 22, 2024 19:19
Emyrk
Emyrk approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very reasonable.

@mafredri mafredri marked this pull request as ready for review March 25, 2024 10:20
@mafredri mafredri merged commit f34592f into main Mar 25, 2024
@mafredri mafredri deleted the mafredri/03-22-fix_coderd_skip_logging_error_for_cancelled_query_in_agent_report_stats branch March 25, 2024 10:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @Emyrk