Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(cli): unhide support bundle cmd #12745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cli/support.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ func (r *RootCmd) support() *serpent.Command {
Handler: func(inv *serpent.Invocation) error {
return inv.Command.HelpHandler(inv)
},
Hidden: true, // TODO: un-hide once the must-haves from #12160 are completed.
Children: []*serpent.Command{
r.supportBundle(),
},
Expand All @@ -40,7 +39,7 @@ func (r *RootCmd) support() *serpent.Command {

var supportBundleBlurb = cliui.Bold("This will collect the following information:\n") +
` - Coder deployment version
- Coder deployment Configuration (sanitized), including enabled experiments
- Coder deployment Configuration (sanitized), including enabled experiments
- Coder deployment health snapshot
- Coder deployment Network troubleshooting information
- Workspace configuration, parameters, and build logs
Expand Down
24 changes: 20 additions & 4 deletions cli/support_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,19 @@ func TestSupportBundle(t *testing.T) {
t.Run("Workspace", func(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitShort)
client, db := coderdtest.NewWithDatabase(t, nil)
var dc codersdk.DeploymentConfig
secretValue := uuid.NewString()
seedSecretDeploymentOptions(t, &dc, secretValue)
client, db := coderdtest.NewWithDatabase(t, &coderdtest.Options{
DeploymentValues: dc.Values,
})
owner := coderdtest.CreateFirstUser(t, client)
randSecretValue := uuid.NewString()
r := dbfake.WorkspaceBuild(t, db, database.Workspace{
OrganizationID: owner.OrganizationID,
OwnerID: owner.UserID,
}).WithAgent(func(agents []*proto.Agent) []*proto.Agent {
// This should not show up in the bundle output
agents[0].Env["SECRET_VALUE"] = randSecretValue
agents[0].Env["SECRET_VALUE"] = secretValue
return agents
}).Do()
ws, err := client.Workspace(ctx, r.Workspace.ID)
Expand Down Expand Up @@ -89,7 +93,7 @@ func TestSupportBundle(t *testing.T) {
clitest.SetupConfig(t, client, root)
err = inv.Run()
require.NoError(t, err)
assertBundleContents(t, path, randSecretValue)
assertBundleContents(t, path, secretValue)
})

t.Run("NoWorkspace", func(t *testing.T) {
Expand Down Expand Up @@ -263,3 +267,15 @@ func assertDoesNotContain(t *testing.T, f *zip.File, vals ...string) {
}
}
}

func seedSecretDeploymentOptions(t *testing.T, dc *codersdk.DeploymentConfig, secretValue string) {
t.Helper()
if dc == nil {
dc = &codersdk.DeploymentConfig{}
}
for _, opt := range dc.Options {
if codersdk.IsSecretDeploymentOption(opt) {
opt.Value.Set(secretValue)
}
}
}
2 changes: 2 additions & 0 deletions cli/testdata/coder_--help.golden
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ SUBCOMMANDS:
stat Show resource usage for the current workspace.
state Manually manage Terraform state to fix broken workspaces
stop Stop a workspace
support Commands for troubleshooting issues with a Coder
deployment.
templates Manage templates
tokens Manage personal access tokens
unfavorite Remove a workspace from your favorites
Expand Down
13 changes: 13 additions & 0 deletions cli/testdata/coder_support_--help.golden
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
coder v0.0.0-devel

USAGE:
coder support

Commands for troubleshooting issues with a Coder deployment.

SUBCOMMANDS:
bundle Generate a support bundle to troubleshoot issues connecting to a
workspace.

———
Run `coder --help` for a list of global options.
25 changes: 25 additions & 0 deletions cli/testdata/coder_support_bundle_--help.golden
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
coder v0.0.0-devel

USAGE:
coder support bundle [flags] <workspace> [<agent>]

Generate a support bundle to troubleshoot issues connecting to a workspace.

This command generates a file containing detailed troubleshooting information
about the Coder deployment and workspace connections. You must specify a
single workspace (and optionally an agent name).

OPTIONS:
-O, --output-file string, $CODER_SUPPORT_BUNDLE_OUTPUT_FILE
File path for writing the generated support bundle. Defaults to
coder-support-$(date +%s).zip.

--url-override string, $CODER_SUPPORT_BUNDLE_URL_OVERRIDE
Override the URL to your Coder deployment. This may be useful, for
example, if you need to troubleshoot a specific Coder replica.

-y, --yes bool
Bypass prompts.

———
Run `coder --help` for a list of global options.
1 change: 1 addition & 0 deletions docs/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ Coder — A tool for provisioning self-hosted development environments with Terr
| [<code>stop</code>](./cli/stop.md) | Stop a workspace |
| [<code>unfavorite</code>](./cli/unfavorite.md) | Remove a workspace from your favorites |
| [<code>update</code>](./cli/update.md) | Will update and start a given workspace if it is out of date |
| [<code>support</code>](./cli/support.md) | Commands for troubleshooting issues with a Coder deployment. |
| [<code>server</code>](./cli/server.md) | Start a Coder server |
| [<code>features</code>](./cli/features.md) | List Enterprise features |
| [<code>licenses</code>](./cli/licenses.md) | Add, delete, and list licenses |
Expand Down
17 changes: 17 additions & 0 deletions docs/cli/support.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

45 changes: 45 additions & 0 deletions docs/cli/support_bundle.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions docs/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -900,6 +900,16 @@
"description": "Stop a workspace",
"path": "cli/stop.md"
},
{
"title": "support",
"description": "Commands for troubleshooting issues with a Coder deployment.",
"path": "cli/support.md"
},
{
"title": "support bundle",
"description": "Generate a support bundle to troubleshoot issues connecting to a workspace.",
"path": "cli/support_bundle.md"
},
{
"title": "templates",
"description": "Manage templates",
Expand Down