Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: reduce azure CA cert validity check period to 2 months #12788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2024
Merged

chore: reduce azure CA cert validity check period to 2 months #12788

merged 1 commit into from
Mar 28, 2024

Conversation

dannykopping
Copy link
Contributor

coderd/azureidentity/azureidentity_test.go:TestExpiresSoon is failing currently, because a few Azure certificates have not yet been renewed.

For example, Microsoft Azure TLS Issuing CA 01:

$ curl -s https://crt.sh/\?d\=2616326024 | openssl x509 -in /dev/stdin -text | grep -e Validity -A2 -e Subject:    
        Validity
            Not Before: Jan 17 20:22:47 2020 GMT
            Not After : Jun 27 20:22:47 2024 GMT
        Subject: C = US, O = Microsoft Corporation, CN = Microsoft Azure TLS Issuing CA 01
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption

Tagging @spikecurtis since you last changed this

@spikecurtis Graphite App
Copy link
Contributor

Have they still not been replaced? Like, not just that they are expiring, but there is nothing to take their place?

@dannykopping
Copy link
Contributor Author

Have they still not been replaced? Like, not just that they are expiring, but there is nothing to take their place?

Not AFAICS on https://learn.microsoft.com/en-us/azure/security/fundamentals/azure-ca-details?tabs=root-and-subordinate-cas-list. At least, I just looked to see if the existing certs had been updated - I'm not sure if anything supersedes these.

@dannykopping dannykopping merged commit d734f3f into coder:main Mar 28, 2024
@dannykopping dannykopping deleted the dk/chill-az branch March 28, 2024 09:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

@dannykopping dannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannykopping @spikecurtis