refactor: Move package.json and other front-end collateral into 'site' #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe-coder
commented
Feb 1, 2022
| @@ -78,8 +78,8 @@ const ProjectPage: React.FC = () => { | |||
| <div className={styles.root}> | |||
| <Navbar user={me} onSignOut={signOut} /> | |||
| <Header | |||
| title={firstOrItem(project)} | |||
| description={firstOrItem(organization)} | |||
| title={firstOrItem(project, "")} | |||
There was a problem hiding this comment.
There were a couple places where the type-checks became stricter! I figured it was easier to leave them on in the stricter mode, and fix them, then to figure out how to turn them off
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 71.66% 70.54% -1.12%
==========================================
Files 92 96 +4
Lines 4168 4254 +86
Branches 59 68 +9
==========================================
+ Hits 2987 3001 +14
- Misses 935 1010 +75
+ Partials 246 243 -3
Continue to review full report at Codecov.
|
kylecarbs
approved these changes
Feb 1, 2022
This was referenced Feb 1, 2022
bryphe-coder
added a commit
that referenced
this pull request
Feb 1, 2022
…139) Unfortunately along with #133 I missed one other item in moving files to `/site` in #128 - ignoring new configuration files (and other folders) in our `jest.config.js`. This caused our coverage numbers in front-end code to dip, because files that shouldn't be included (and previously weren't included) were now being tracked for coverage.
bryphe-coder
added a commit
that referenced
this pull request
Feb 2, 2022
Hopefully the last thing I missed in #128 ... this fixes the `./develop.sh` script and `site/dev.ts` to account for the new pathing of `package.json`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the front-end collateral to all live within
site- so nopackage.jsonat the root.The reason we had this initially is that the jest test run and NextJS actually require having two different
tsconfigs - Next needsjsx:"preserve", while jest needsjsx:"react"- we were usingtsconfigs at different levels at the hierarchy to manage this.I changed this behavior to still use two different
tsconfig.jsons, which is mandatory - but just side-by-side insite.Once that's fixed, it was easy to move everything into
siteFollow up from: #118 (comment)