Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: describe mutually exclusive create workspace template fields #12834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Apr 1, 2024

Ideally we could do this in the OpenAPI spec, but there is no first class "mutually exclusive" feature in OpenAPI. So in lieu of something more complex, or changing our struct/validation, a description comment should suffice.

I added the description to both the struct and the api call. So any place the fields are encountered in the docs, there should be the description of the mutually exclusive fields.

Closes #12090

Ideally we could do this in the OpenAPI spec, but there is no first
class "mutually exclusive" feature in OpenAPI. So in lieu of something
more complex, or changing our struct/validation, a description comment
should suffice.
@Emyrk Emyrk requested a review from stirby April 1, 2024 17:58
Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Emyrk Emyrk merged commit b5b5c37 into main Apr 2, 2024
@Emyrk Emyrk deleted the stevenmasley/document_mutually_exclusive branch April 2, 2024 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change template_version_id -> template_active_version_id in API docs
2 participants