fix: Prefix paths in find on macOS #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes paths not resolving in macOS, causing the build target to fail. This also renames the site target to specify the index.html, which is the output artifact of building the site.
Codecov Report
@@ Coverage Diff @@
## main #1284 +/- ##
==========================================
- Coverage 66.20% 66.12% -0.09%
==========================================
Files 280 280
Lines 18389 18389
Branches 216 216
==========================================
- Hits 12174 12159 -15
- Misses 4956 4969 +13
- Partials 1259 1261 +2
Continue to review full report at Codecov.
|
coadler
approved these changes
May 4, 2022
| @@ -76,7 +76,7 @@ provisionersdk/proto/provisioner.pb.go: provisionersdk/proto/provisioner.proto | |||
| --go-drpc_opt=paths=source_relative \ | |||
| ./provisionersdk/proto/provisioner.proto | |||
|
|
|||
| site/out: $(shell find ./site -not -path './site/node_modules/*' -type f -name '*.tsx') $(shell find ./site -not -path './site/node_modules/*' -type f -name '*.ts') site/package.json | |||
| site/out/index.html: $(shell find ./site -not -path './site/node_modules/*' -type f -name '*.tsx') $(shell find ./site -not -path './site/node_modules/*' -type f -name '*.ts') site/package.json | |||
There was a problem hiding this comment.
Could do something like this to not have to duplicate it twice
echo "*.tsx *.ts" | xargs -n1 find ./site -not -path './site/node_modules/*' -type f -nameThere was a problem hiding this comment.
Auto-merge bites me yet again
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This fixes paths not resolving in macOS, causing the build target to fail. This also renames the site target to specify the index.html, which is the output artifact of building the site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes paths not resolving in macOS, causing
the build target to fail. This also renames the
site target to specify the index.html, which is
the output artifact of building the site.