Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: ensure correct version of sqlc is executed #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

fix: ensure correct version of sqlc is executed #1287

merged 1 commit into from
May 4, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented May 4, 2022 •
edited
Loading

If /usr/local/bin is searched before $GOPATH/bin in your $PATH the wrong
version of sqlc can be executed.

@coadler coadler self-assigned this May 4, 2022
@coadler coadler requested a review from kylecarbs May 4, 2022 20:00
@coadler
fix: ensure correct version of sqlc is executed
7eba4e7 
If `/usr/local/bin` is searched before `$GOPATH/bin` in your `$PATH` the
wrong version of `sqlc` can be executed.
@coadler coadler enabled auto-merge (squash) May 4, 2022 20:04
@codecov
Copy link

codecov bot commented May 4, 2022 •
edited
Loading

Codecov Report

Merging #1287 (7eba4e7) into main (d7f6321) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
- Coverage   66.15%   66.01%   -0.15%     
==========================================
  Files         281      277       -4     
  Lines       18424    18224     -200     
  Branches      220      220              
==========================================
- Hits        12188    12030     -158     
+ Misses       4975     4944      -31     
+ Partials     1261     1250      -11
Flag Coverage Δ
unittest-go-macos-latest 53.42% <ø> (-0.10%) ⬇️
unittest-go-postgres- 65.03% <ø> (+0.04%) ⬆️
unittest-go-ubuntu-latest 55.95% <ø> (-0.05%) ⬇️
unittest-go-windows-2022 ?
unittest-js 71.61% <ø> (ø)
Impacted Files Coverage Δ
cli/configssh.go 62.04% <0.00%> (-6.57%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
agent/agent.go 64.66% <0.00%> (-2.48%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
provisioner/terraform/provision.go 71.89% <0.00%> (-0.41%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (ø)
pty/pty_windows.go
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f6321...7eba4e7. Read the comment docs.

@coadler coadler merged commit 0ccf010 into main May 4, 2022
@coadler coadler deleted the colin/gen-sqlc branch May 4, 2022 20:09
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@coadler @kylecarbs
fix: ensure correct version of sqlc is executed (#1287)
1060e57 
If `/usr/local/bin` is searched before `$GOPATH/bin` in your `$PATH` the
wrong version of `sqlc` can be executed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @kylecarbs @misskniss