Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: install openrc service on alpine (#12294) #12870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2024
Merged

fix: install openrc service on alpine (#12294) #12870

merged 2 commits into from
May 3, 2024

Conversation

recanman
Copy link
Contributor

@recanman recanman commented Apr 4, 2024 •
edited
Loading

cc: @bpmct

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Apr 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

cdrcommunity added a commit to coder/cla that referenced this pull request Apr 4, 2024
@cdrcommunity
@cdr-bot[bot] has signed the CLA in coder/coder#12870
0fdded6
@kylecarbs
Copy link
Member

@coadler can you review pls as resident alpine?

@github-actions github-actions bot added the stale This issue is like stale bread. label Apr 12, 2024
@matifali matifali removed the stale This issue is like stale bread. label Apr 14, 2024
@github-actions github-actions bot added the stale This issue is like stale bread. label Apr 22, 2024
@matifali matifali requested a review from coadler April 22, 2024 10:14
@github-actions github-actions bot removed the stale This issue is like stale bread. label Apr 23, 2024
kylecarbs
kylecarbs approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the slow review here!

This looks good to me.

@kylecarbs kylecarbs enabled auto-merge (squash) May 3, 2024 21:01
@kylecarbs kylecarbs merged commit b20c63c into coder:main May 3, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@coadler coadler Awaiting requested review from coadler

Assignees

@recanman recanman

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alpine Linux OpenRC Service
3 participants
@recanman @kylecarbs @matifali