Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add unit test for pass through external auth query params #12928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Apr 10, 2024

Unit test added to verify behavior of query params set in the auth url for external apps. This behavior is intended to specifically support Auth0 audience query param.

Example:

CODER_EXTERNAL_AUTH_<n>_AUTH_URL=https://<domain>/oauth2/authorize?audience=<audience>

Unit test added to verify behavior of query params set in the
auth url for external apps. This behavior is intended to specifically
support Auth0 audience query param.
@Emyrk Emyrk changed the title chore: verify pass through external auth query params chore: add unit test for pass through external auth query params Apr 10, 2024
@Emyrk Emyrk requested a review from johnstcn April 10, 2024 17:19
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@Emyrk Emyrk merged commit 566f8f2 into main Apr 10, 2024
23 checks passed
@Emyrk Emyrk deleted the stevenmasley/audience_query_param branch April 10, 2024 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants