Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(coderd/metricscache): avoid logging error for no rows #12988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix(coderd/metricscache): avoid logging error for no rows #12988

merged 1 commit into from
Apr 17, 2024

Conversation

mafredri
Copy link
Member

Fixes #12938

@mafredri mafredri marked this pull request as ready for review April 17, 2024 17:05
@mafredri mafredri requested a review from spikecurtis April 17, 2024 17:05
@mafredri mafredri merged commit 9219044 into main Apr 17, 2024
@mafredri mafredri deleted the mafredri/fix-metric-cache-error-log branch April 17, 2024 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestCollectInsights error log dropped
2 participants
@mafredri @kylecarbs