feat: show version on login page #13033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ export const AgentVersion: FC<AgentVersionProps> = ({ | |||
| ); | |||
|
|
|||
| if (status === agentVersionStatus.Updated) { | |||
| return <span>Updated</span>; | |||
| return null; | |||
There was a problem hiding this comment.
Just checking if we want to do this since this looks to be outside of the scope.
There was a problem hiding this comment.
sneaking in out of scope things is my favorite 😝 but yes, this was intentional
|
The issue request is to show the version in the dashboard footer on all pages all the time. |
the internal issue specifically mentions the login page, so I went with that. adding it to all of the other pages will be a more involved change anyway, so I'm gonna merge this as is, but if we really want it everywhere, I can do another pr later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12909