chore: add build targets to nix flake #13186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables `nix build github:coder/coder#main`!
Member
|
@kylecarbs, could you also update https://github.com/coder/coder/blob/main/dogfood/Dockerfile.nix? |
Member
Author
|
@matifali with what? |
Member
Author
|
@matifali fixed! |
code-asher
approved these changes
May 6, 2024
| pkgs = import nixpkgs { inherit system; config.allowUnfree = true; }; | ||
| formatter = pkgs.nixpkgs-fmt; | ||
| nodejs = pkgs.nodejs-18_x; | ||
| yarn = pkgs.yarn.override { inherit nodejs; }; |
Member
There was a problem hiding this comment.
We might want to either remove yarn from the packages below (since otherwise it could use the wrong Node version) or put this line back. Maybe remove makes more sense since pnpm should be used anyway!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
nix build github:coder/coder[/branch]#linux_amd64!