feat: make it harder to skip graceful shutdown accidentally #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1327 +/- ##
==========================================
+ Coverage 58.09% 66.45% +8.36%
==========================================
Files 282 282
Lines 18521 18522 +1
Branches 231 231
==========================================
+ Hits 10759 12309 +1550
+ Misses 6601 4949 -1652
- Partials 1161 1264 +103
Continue to review full report at Codecov.
|
Signed-off-by: Spike Curtis <[email protected]>
|
TIL about I realize this PR is merged but wanted to give a heads up about non-English keyboard users who'd have to hit Edit: Actually that combination doesn't even work (I just tested), you get |
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* feat: make it harder to skip graceful shutdown accidentally Signed-off-by: Spike Curtis <[email protected]> * fixup: don't use unbuffered signal channel Signed-off-by: Spike Curtis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Spike Curtis [email protected]
Makes it harder to accidentally skip graceful shutdown (which, in
--devmode includes cleaning up workspaces) by not allowing a second ctrl+C to kill the program. If you really want to kill graceful shutdown, you can use ctrl+\ (SIGQUIT).Subtasks
Fixes #631