feat(provisioner): pass owner git ssh key #13366
Conversation
| "CODER_WORKSPACE_OWNER_OIDC_ACCESS_TOKEN="+metadata.GetWorkspaceOwnerOidcAccessToken(), | ||
| "CODER_WORKSPACE_OWNER_GROUPS="+string(ownerGroups), | ||
| "CODER_WORKSPACE_OWNER_SSH_PUBLIC_KEY="+metadata.GetWorkspaceOwnerSshPublicKey(), | ||
| "CODER_WORKSPACE_OWNER_SSH_PRIVATE_KEY="+metadata.GetWorkspaceOwnerSshPrivateKey(), |
There was a problem hiding this comment.
Is this safe to do?
I suppose if the provisioner is compromised all bets are off, but just curious if there is anything we should be sensitive to here in relation to passing the privkey around.
There was a problem hiding this comment.
The safety of these values is predicated on
a) trusting the provisioner that's executing the job,
b) trusting the communication channel between the provisioner and coder.
So if someone can either access the environment variables of the terraform-provider-coder process, or intercept the communication path between provisionerd and coderd, then all bets are off.
Apart from that, this is a sensitive variable just like the OIDC access token or Coder session token that get passed in the same way.
2254e0e to
3a9a7d1
Compare
mafredri
left a comment
There was a problem hiding this comment.
I'd like to see a bit more error handling, but other than that, LGTM!
Related to coder/terraform-provider-coder#219
Passes owner git SSH key to proto metadata that gets passed to the terraform provider.
NOTE: requires a release of coder/terraform-provider-coder before merge.