Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(scripts): add safety check for difference between dry run release notes #13398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mafredri merged 1 commit into from
May 29, 2024
Merged

chore(scripts): add safety check for difference between dry run release notes #13398

mafredri merged 1 commit into from
May 29, 2024

Conversation

@mafredri
Copy link
Member

@mafredri mafredri commented May 29, 2024

Just a little QoL change to prevent accidents:

WARNING: Release notes differ from dry-run version:

--- build/RELEASE-v2.12.0-DRYRUN.md	2024-05-29 21:33:03
+++ build/RELEASE-v2.12.0.md	2024-05-29 21:39:27
@@ -5,10 +5,6 @@

 ### Features

-Hello there!
-
-Important note!!!
-
 - Server: Add `times_used` to `coder_app`s in insights API (#13292, a0fce363c) (@mafredri)
 - Server: Add endpoints for editing and deleting organizations (#13287, 3f1e9c038) (@aslilac)
 - Provisioner: Pass owner git ssh key (#13366, cca3cb1c5) (@johnstcn)

Continue with the new release notes anyway? (y/n) y

Preview release notes? (y/n)

@mafredri mafredri self-assigned this May 29, 2024
@mafredri mafredri requested review from coadler and stirby May 29, 2024 18:41
@mafredri mafredri merged commit 9eb797e into main May 29, 2024
@mafredri mafredri deleted the mafredri/chore-release-notes-safety-check branch May 29, 2024 19:01
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stirby stirby stirby approved these changes

+1 more reviewer

@coadler coadler coadler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mafredri mafredri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mafredri @coadler @stirby