Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: use static port number for prometheus test #14000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2024
Merged

fix: use static port number for prometheus test #14000

merged 2 commits into from
Jul 24, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jul 24, 2024

Fixes: #13931
Related: #13999

This PR modifies the logic to assign a static port to the Prometheus endpoint. We can't use this port for other purposes.

@mtojek mtojek self-assigned this Jul 24, 2024
@mtojek mtojek requested a review from dannykopping July 24, 2024 12:43
@mtojek mtojek marked this pull request as ready for review July 24, 2024 12:43
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this will work.

@mtojek mtojek enabled auto-merge (squash) July 24, 2024 12:51
@mtojek mtojek merged commit b3a3671 into main Jul 24, 2024
32 checks passed
@mtojek mtojek deleted the 13931-port-3 branch July 24, 2024 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: TestProvisionerDaemon_SessionToken/PrometheusEnabled
2 participants